Pretty printing for named closures #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorybchris
temporarily deployed
to
scrapscript-pr-121
GitHub Actions
Inactive
|
nit: can you make the commit title have a verb and active voice |
tekknolagi
reviewed
May 24, 2024
scrapscript.py
Outdated
| # If creating a Closure with an Assign we can specify a name for the | ||
| # Closure, which may be useful for debugging. | ||
| print("Setting closure with name ", exp.name.name) | ||
| value = Closure(value.env, value.func, name=exp.name.name) |
There was a problem hiding this comment.
If you do
a = x -> x
b = a
what happens?
There was a problem hiding this comment.
An alternative would be catching this in the parser where we see a pattern of Assign(x, Function()) or Assign(x, MatchFunction()) and plumb it through Function too
gregorybchris
temporarily deployed
to
scrapscript-pr-121
GitHub Actions
Inactive
|
a) maybe switch to the parser approach and |
|
looking good though! |
gregorybchris
force-pushed
the
chris/closure-print
branch
from
0d7863b
to
e957ff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.