Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reach points to the project #464

Closed
wants to merge 2 commits into from
Closed

Add reach points to the project #464

wants to merge 2 commits into from

Conversation

ponceta
Copy link
Member

@ponceta ponceta commented Oct 16, 2024

General

  • Fix several bugs

Describe your changes

  • Add reach points to the project visible from scale 1:100
  • Set as mandatory fk_dataowner fk_provider for reach points, wastewater structures, reaches
  • Set rule on reach attributes to avoid rp_obj_id duplication

Screenshots

image

Issue ticket number and link

Fix :

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • CI Tests are green
  • The documentation is up to date with the proposed change.
  • My work is ready for review

Checklist before merge

  • A review has been performed
  • Comments are resolved
  • Documentation is ready

Add reach points to the project
@ponceta ponceta self-assigned this Oct 16, 2024
@ponceta ponceta added the fix Fixing something not working label Oct 16, 2024
@ponceta ponceta requested review from urskaufmann, cymed and sjib October 16, 2024 08:05
@ponceta
Copy link
Member Author

ponceta commented Oct 16, 2024

As this is central, I would be glad to have some testing on this!

@ponceta
Copy link
Member Author

ponceta commented Oct 16, 2024

This is based on old main branch, I have to redo all my changes... I'll open a new PR.

@ponceta ponceta closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing something not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant