Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several bugs on QGIS .qgs project #465

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

ponceta
Copy link
Member

@ponceta ponceta commented Oct 16, 2024

General

  • Fix several bugs

Describe your changes

  • Set as mandatory fk_dataowner fk_provider for reach points, wastewater structures, reaches
  • Set rule on reach attributes to avoid rp_obj_id duplication
  • Removed : Add reach points to the project visible from scale 1:100

Screenshots

image

Issue ticket number and link

Fix :

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • CI Tests are green
  • The documentation is up to date with the proposed change.
  • My work is ready for review

Checklist before merge

  • A review has been performed
  • Comments are resolved
  • Documentation is ready

Fix duplicate vw_wastewater_structure layer
Add reach points and fix reach cutting
@ponceta ponceta requested review from urskaufmann, sjib and cymed October 16, 2024 08:53
@ponceta
Copy link
Member Author

ponceta commented Oct 16, 2024

Cutting is working as expected if reaches have a correct 3D Geometry :

image

image

image

Link between reaches has to be set with the connect tool, usually a wastewater structure / wastewater node will be set on that point.

@ponceta ponceta self-assigned this Oct 16, 2024
@ponceta ponceta added QGIS project Concern the .qgs QGIS project fix Fixing something not working labels Oct 16, 2024
@ponceta ponceta mentioned this pull request Oct 16, 2024
@urskaufmann
Copy link
Contributor

This cutting is on one side a help (I have less manual work), on the other side there is a lot of things to think about when using this cut (levels, connections, also connections of other reaches to the trimmed reach (Blindanschluss)). The wish for a complete tool remains...

@urskaufmann
Copy link
Contributor

3d geometry: As long as I can not export/import the 3d geometry, I will not enforce this 3d thing.

Vision until the ili-definition supports 3d: TEKSI exports always (user to not care about) together with the xtf a exchange-file with 3d-geometries. When importing and this exchange file exist, TEKSI imports after the xtf-part also the 3d part and updates the geometries.

@ponceta ponceta closed this Oct 16, 2024
@ponceta ponceta reopened this Oct 16, 2024
@cymed
Copy link
Contributor

cymed commented Oct 18, 2024

General question: Why do we need the visualisation of the reach points in the project? We can access the data via vw_tww_reach.

@ponceta
Copy link
Member Author

ponceta commented Oct 18, 2024

General question: Why do we need the visualisation of the reach points in the project? We can access the data via vw_tww_reach.

  • Actually only for debugging purpose now. I'll draw it back from this PR so we can still add it manually when needed.

It could be nice to display visually the outlet shapes and altitudes / in the future to edit the reach start or end point.

Remove reach_points layer
@ponceta
Copy link
Member Author

ponceta commented Oct 18, 2024

Reach point layer has been removed.

…g QGIS project

Add scheduled task for project translation and creating a downloadable package for PR altering QGIS project
@ponceta ponceta merged commit 4072050 into main Oct 25, 2024
2 checks passed
@ponceta ponceta deleted the poa_add_reach_points_v2 branch October 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing something not working QGIS project Concern the .qgs QGIS project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants