Initiate Conformance Test Suite #7826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
|
It might also be helpful for us to create the |
This commit initiates the OSS conformance test suite. It sets the standards for incrementing the V1 conformance test with the two simple test cases. /kind misc
JeromeJu
force-pushed
the
conformance-test-suite
branch
from
672b463 to
9845ffe
Compare
3 tasks
|
cc @tektoncd/core-maintainers PTAL 🙏 |
|
cc @afrittoli @chitrangpatel @vdemeester @Yongxuanzhang thanks for your time in advance 🙏 |
Yongxuanzhang
approved these changes
Apr 9, 2024
| return fmt.Errorf("Expect vendor service to populate Condition Reason %s but got: %s", expectedReason, cond.Reason) | ||
| } | ||
|
|
||
| hasSucceededConditionType = true |
There was a problem hiding this comment.
can we just return nil here?
tekton-robot
added
the
approved
chitrangpatel
approved these changes
Apr 11, 2024
vdemeester
approved these changes
Apr 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, vdemeester, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit initiates the OSS conformance test suite. It sets the
standards for incrementing the V1 conformance test with the two simple
test cases.
/kind misc
part of #7828
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes