Update golangci version and configuration, and fix errors #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/cleanup
|
The following is the coverage report on the affected files.
|
vdemeester
force-pushed
the
some-linting-updates
branch
from
d58d050 to
245fd36
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
JeromeJu
reviewed
Apr 4, 2024
This is a relatively huge commit that updates the golangci-lint version as well as configuration. ``` make golangci-lint 🐱 running golangci-lint… WARN [linters_context] copyloopvar: this linter is disabled because the Go version (1.21) of your project is lower than Go 1.22 Compilation finished at Thu Apr 4 13:44:19 ``` Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
some-linting-updates
branch
from
245fd36 to
0d8234e
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
chitrangpatel
approved these changes
Apr 4, 2024
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a relatively huge commit that updates the golangci-lint version as well as configuration.
(from 296 errors to 0 😅 )
/kind cleanup
/cc @tektoncd/core-maintainers
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes