fix(pipelinerun): resolve issue where canceling active pipelinerun fails

[l-qing]

fix #8172

When canceling a PipelineRun, validation errors returned when canceling a completed TaskRun should be ignored.

The fix needs to be synchronized to v0.62.x.

Solution

I have considered these solutions, but ultimately chose the current approach.

1. Avoid modifying the spec.status of completed TaskRuns in the defaults of TaskRun.

This does not make sense; business logic should not be handled in setdefaults.

2. Change the validation of TaskRun to also allow the spec.status of completed TaskRuns to be modified.

This also does not comply with the agreement. The *Run resource has been completed, and modifying the spec is indeed not advisable.

3. When canceling taskRun in PipelineRun, only cancel unfinished taskRuns.

This approach does not completely solve the problem because it is possible that TaskRun was incomplete when it was retrieved but had already completed by the time it was modified.

4. Ignore a certain type of error when canceling TaskRun.

Similar to ignoring not found errors with the current approach, this is quite reasonable.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

fix(pipelinerun): resolve issue where canceling active pipelinerun fails

/kind bug

[tekton-robot]

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/cancel.go	93.2%	91.8%	-1.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/cancel.go	93.2%	91.8%	-1.4

[vdemeester]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/cancel.go	93.2%	91.8%	-1.4

[l-qing]

/retest-required

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/cancel.go	93.2%	91.8%	-1.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/cancel.go	93.2%	91.8%	-1.4

[l-qing]

/auto-cc

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hrivera-ntap]

Thanks for the quick fix @l-qing! Can someone help get this merged?

Thanks!
-Rob

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/cancel.go	93.2%	91.8%	-1.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/cancel.go	93.2%	91.8%	-1.4

[chitrangpatel]

/lgtm

[chitrangpatel]

/lgtm