Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue-1711-: Metrics not getting update correctly for eventlistener_event_count #1755

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

sudhishmk
Copy link
Contributor

@sudhishmk sudhishmk commented Jul 30, 2024

fix for issue-1711-: Metrics not getting update correctly for eventlistener_event_count

Issue -: eventlistener_event_count metrics is not updated correctly

eventlistener_client_results{name=""} 34
# HELP eventlistener_event_count Number of events sent
# TYPE eventlistener_event_count counter
eventlistener_event_count{event_source="",event_type="",name="",namespace_name="",resource_group="",response_code="",response_code_class="",response_error="",response_timeout=""} 404
# HELP eventlistener_go_alloc The number of bytes of allocated heap objects

Metrics Output After the changes

# HELP eventlistener_event_received_count number of events received by sink
# TYPE eventlistener_event_received_count counter
eventlistener_event_received_count{status="succeeded"} 1

Fix -: Metric name updated from " eventlistener_event_count" to "eventlistener_event_received_count".
Docs updated

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 30, 2024
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 30, 2024
@sudhishmk
Copy link
Contributor Author

/retest

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudhishmk Can you run gofmt on the files? CI tests are failing due to this.

@sudhishmk
Copy link
Contributor Author

@sudhishmk Can you run gofmt on the files? CI tests are failing due to this.

Done

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@khrm
Copy link
Contributor

khrm commented Aug 20, 2024

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@savitaashture
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@tekton-robot tekton-robot merged commit 18ebe5c into tektoncd:main Aug 21, 2024
6 checks passed
@savitaashture savitaashture added the kind/bug Categorizes issue or PR as related to a bug. label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants