Development for 2.0 #17
Conversation
- either `value` or `defaultValue` - add formProps - correct value, disabled, defaultValue precedence
| @@ -42,7 +42,7 @@ export const inputValueLookup = (serializedValues, inputName) => { | |||
| var attrName = Object.keys(inputNameTree)[0]; // inputName describes only single path | |||
|
|
|||
| var next = inputNameTree[attrName]; | |||
| if (next == null) return null; // if it's already leaf, then no chance to be found. | |||
| if (next == null) return undefined; // if it's already leaf, then no chance to be found. | |||
There was a problem hiding this comment.
the returned value should be fixed to undefined when it's not found. (related issue #18)
| className: 'field', | ||
| field: def, |
There was a problem hiding this comment.
field is redundant, as fieldProps is already merged in line 83. related issue #19
| disabled: disabled | ||
| disabled: disabled, | ||
|
|
||
| defaultValue: typeof value !== 'undefined' ? undefined : defaultValue, |
There was a problem hiding this comment.
if there is value, defaultValue should not be used, this will cause a react warning/error complaining about both should not exist at the same time
related issue: #21
| label: label, | ||
| error: error, |
| disabled: disabled, | ||
|
|
||
| defaultValue: typeof value !== 'undefined' ? undefined : defaultValue, | ||
| formProps: formProps |
There was a problem hiding this comment.
this is a new key: formProps allows passing of parent props.
The useful use case could be passing errors, or calling change handler e.g. onFieldValueChanged(name, e)
related issue: #20
| : inputValueLookup(formProps.defaultValues || {}, name); | ||
|
|
||
| // fieldProps.value > formProps.values(field).value | ||
| const value = typeof fieldProps.value !== 'undefined' |
There was a problem hiding this comment.
In the refactoring, it reduces the inherited properties to only 3 important ones:
disabled-form.disabledshould disable all child fieldsdefaultValue- extractedform.props.defaultValuesvalue- extracted fromform.props.values
related issue #19
| export const layout = (...children) => { | ||
| return ( | ||
| <div key={`layout-${layoutCount++}`} className="layout"> |
| @@ -19,7 +17,7 @@ export const section = (name, ...rows) => { | |||
| ); | |||
| }); | |||
| return ( | |||
| <div key={`section-${sectionCount++}`} className="section"> | |||
2.0.0:
inputValueLookupreturns null, instead of undefined for failed lookupformProps#20 addingformPropsvalueanddefaultValuecauses react warning. #21 coexistence ofdefaultValueandvaluecauses react warning