Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable class overriding #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enable class overriding #7

wants to merge 2 commits into from

Conversation

alvinsj
Copy link

@alvinsj alvinsj commented Jul 3, 2018

No description provided.

@alvinsj alvinsj requested a review from olejrosendahl July 3, 2018 03:23
olejrosendahl
olejrosendahl requested changes Jul 3, 2018
View reviewed changes
Copy link
Member

@olejrosendahl olejrosendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for the new option.

@alvinsj
Copy link
Author

alvinsj commented Jul 3, 2018

@olejrosendahl added test

olejrosendahl
olejrosendahl approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@olejrosendahl olejrosendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olejrosendahl olejrosendahl olejrosendahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvinsj @olejrosendahl