Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajuste de log en módulo de autenticación #83

Merged
merged 3 commits into from
May 20, 2024
Merged

Ajuste de log en módulo de autenticación #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f2f888
Update auth.py
mapedraza Feb 2, 2024
27e6d98
ADD Changelog entry
fgalan May 20, 2024
5f66c64
Merge branch 'master' into task/fix-auth-log-info-subservice
fgalan May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python-lib/tc_etl_lib/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,8 @@ TOTAL 403 221 45%

- Add: new optional parameters `timeout`, `post_retry_connect`, `post_retry_backoff_factor` in the iotaManager constructor used in the timeout/retry logic in send_http and send_batch_http ([#72](https://github.com/telefonicasc/etl-framework/issues/72))

- Fix: improve INFO log traces ([#82](https://github.com/telefonicasc/etl-framework/pull/82))

- Fix: rename sensor_id to device_id in iotManager to align with the term used in IOTA library ([#77](https://github.com/telefonicasc/etl-framework/pull/77))

0.11.0 (February 2nd, 2024)
Expand Down
2 changes: 1 addition & 1 deletion python-lib/tc_etl_lib/tc_etl_lib/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def get_info(self):
if (hasattr(self, "service")):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aunque sea un minor, por completitud, sugiero añadir una entrada en el Changelog (está en no se que markdown que ahora no recuerdo pero debe ser fácil de localiza :). Algo estilo:

- Fix: improve INFO log traces [#82](https://github.com/telefonicasc/etl-framework/pull/82)

logger.info(f'service: {self.service}')
if (hasattr(self, "subservice")):
logger.info(f'service: {self.subservice}')
logger.info(f'subservice: {self.subservice}')
if (hasattr(self, "user")):
logger.info(f'user: {self.user}')
if (hasattr(self, "password")):
Expand Down
Loading