Make it possible to override log configuration options

[k1rd3rf]

This resolves #76

[tenstad]

Suggested change

	type = any
	type = map

Not quite sure how terraform whould handle maps vs objects 🤔

[k1rd3rf]

At least when declaring a i.e. object({key1: string, key2: number}), it will only pass on the declared ones, so if I sent in var_name = { keyNotDeclared = "someValue" } it wouldn't be included where it was used.

[k1rd3rf]

So it might work with map. I will take a look.

[k1rd3rf]

You need to specify everything inside map({ ... }) :/

[larstobi]

There is a defined number of options available for the hard coded awslogs driver in the module. These are documented here:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/using_awslogs.html#create_awslogs_logdriver_options

We are currently setting the awslogs-group, awslogs-region and awslogs-stream-prefix options.

And, as you can see, we have already provided a way to override the awslogs-group option. Maybe you can use the same method to override awslogs-region and awslogs-stream-prefix instead?

Can you provide an example of why you need this?

[larstobi]

I just had a look at your other #81 PR, and I think these two PRs should be handled together. Since, if you override the log driver, then the default options listed above are wrong.

Fargate supports three different log drivers: awslogs, splunk, and awsfirelens. If we want to support those, then I think we need a conditional for adding the awslogs options that we add by default.

Also, I think we don't want to merge() these other options in with the awslogs options, but rather replace the content of the options key og the logConfiguration altogether.

[k1rd3rf]

I agree with everything you write. It is way more than I initially needed, so lets just close this PR and also #81.