Add an optional health check to the container definition (#15) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update enables passing a health check object to the container so that ECS can evaluate the task health - very useful if you are not using an ALB / target groups
|
Thanks, @colincoleman , for the purpose as well as the code update. It's quite comprehensive and helpful. |
The target group name was added for readability but was orignially excluded because of problems destroying a target group while a listener was attached. See comment in code. This was removed again in case this was still an issue and becuase of a length limit of 32 chars for the name parameter which was causing problems
k1rd3rf
reviewed
Aug 25, 2023
Comment on lines
+166
to
167
| "healthCheck" : var.container_health_check | ||
| }, local.task_container_secrets, local.repository_credentials) |
There was a problem hiding this comment.
Following the pattern of some of the other optional variables (line 136-141), you could do something like
Suggested change
| "healthCheck" : var.container_health_check | |
| }, local.task_container_secrets, local.repository_credentials) | |
| }, local.task_container_secrets, local.repository_credentials, local.task_container_health_check) | |
| task_container_health_check = var.container_health_check != null ? { "healthCheck" = var.container_health_check } : null |
larstobi
reviewed
Dec 8, 2023
| })) | ||
| description = "(Optional) Container ulimit settings. This is a list of maps, where each map should contain \"name\", \"hardLimit\" and \"softLimit\"" | ||
| default = null | ||
| } |
larstobi
reviewed
Dec 8, 2023
| @@ -93,7 +93,6 @@ resource "aws_security_group_rule" "egress_service" { | |||
| # LB Target group | |||
| # ------------------------------------------------------------------------------ | |||
| resource "aws_lb_target_group" "task" { | |||
| name = "${var.name_prefix}-${var.task_container_port}" | |||
There was a problem hiding this comment.
Removing name forces new resource.
* Bump gopkg.in/yaml.v3 from 3.0.0-20210107192922-496545a6307b to 3.0.0 (telia-oss#88) Bumps gopkg.in/yaml.v3 from 3.0.0-20210107192922-496545a6307b to 3.0.0. --- updated-dependencies: - dependency-name: gopkg.in/yaml.v3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add optional capacity provider strategy (telia-oss#85) * Add option to set a healthCheck property on the task container definition (telia-oss#91) * Allow higher versions of null provider (telia-oss#92) * Allow higher versions of null provider * Bump Taskfile schema version * Use Cantara version of container health check --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Feraudet Cyril <[email protected]> Co-authored-by: Fredrik Oterholt <[email protected]> Co-authored-by: Pål Sollie <[email protected]>
* Add tags to ECS task definition This was missing (maybe it wasn't available when this was first written?) * Add missing tags to ECS Service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enables passing a health check object to the container so that ECS can evaluate the task health - very useful if you are not using an ALB / target groups