Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #487 #524 #564

Open
wants to merge 345 commits into
base: master
Choose a base branch
from
Open

Feature #487 #524 #564

wants to merge 345 commits into from

Conversation

andiempettJISC
Copy link
Collaborator

If galicaster restarts during a recording, on the next long heartbeat with an iCal update if the recording should still be happening it is resumed. once the recording is finished any track files belonging to the recording in rectemp are concatenated with ffmpeg and put into the correct mediapackage to then be ingested.
there is also an option to delay the file concatenation and ingest until nightly time (this is to allow a recording in quick successtion to not wait for this job to complete)

[repository]
recoverytype = save

[plugins]
checkrepo = True

[checkrepo]
to_merge = True
delay_merge = False

its important to note some changes were made to galicaster behaviour around file recovery to accomadate this.
on galicaster restart autorecover 'full' recoverytype was always active, this has now been made configurable via the 'autorecover' option as with error handling. and for this plugin should be set to 'save'
only manual recordings should be given a prefix of "Recovered - " when autorecovered as this changes metadata for opencast scheduled recordings. maybe this information is better in the galicaster.xml if UI notification of a recovered MP is needed. this is not addressed here

Alfro and others added 30 commits April 7, 2017 15:28
@Alfro
Merge pull request teltek#501 from teltek/bugfix_492
965fa7f 
Fix enable/disable preview in rtp bin
@Alfro
Merge pull request teltek#500 from teltek/bugfix_494
ad64e24 
Reword timeout in scheduler teltek#494
@dpeite
Added custom exception in DBusService
5bca333
@Alfro
Merge pull request teltek#502 from teltek/bugfix_refactor_dbus_service
630a469 
Added custom exception in DBusService
@dpeite
Undo commit aac879c teltek#466
61d9b5d
@Alfro
Merge pull request teltek#503 from teltek/bugfix_493
2be5588 
Added missing async properties in audio sinks fixes teltek#493
@dpeite
Fix exception in recorderui teltek#466
2545af6
@dpeite
Send offline status to Opencast when exiting teltek#455
dd18710
@Alfro
Merge pull request teltek#504 from teltek/feature_455
616a044 
Send offline status to Opencast when exiting teltek#455
@Alfro
Merge branch '2.0.x'
c416c4a
@dpeite
Added plugin to set error state if audio is low teltek#495
b2d67c7
@Alfro
teltek#483 heartbeat: Recalculating nightly interval after every exec…
d238267 
…ution
@Alfro
teltek#451 ical: Using DTEND to discard finished recordings
ef73075 
This will allow get_events_from_string_ical() to return an 'ongoing' event
@dpeite
Merge pull request teltek#505 from teltek/bugfix_483_nightly_timer
54ebda8 
teltek#483 heartbeat: Recalculating nightly interval after every execution
@dpeite
RM-12027: Fix setProperty in mediapackage
5c6a90c
@Alfro
Merge pull request teltek#508 from teltek/bugfix_mediapackage_property
f04c4d5 
RM-12027: Fix setProperty in mediapackage
@ppettit
properly validate and parse profile options.
6c27fb1 
this should make it so that validation and parsing of profile
options uses the same logic, see teltek#507
@dpeite
Fix autorecover and test teltek#491
a8da1f8
@Alfro
Merge pull request teltek#509 from teltek/bugfix_491
288f03f 
Fix autorecover and test teltek#491
@ppettit
refactor profile validation
6c60f73
@ppettit
remove unused iumports
8e1f350
@ppettit
restore accidentally commented out section
b87459c
@ppettit
add option to dump dot file of gstreamer pipeline.
d9712a6 
Set `GST_DEBUG_DUMP_DOT_DIR` env var to a path in order to activate.
Does nothing if not set.

use `xdot` to view the files directly or convert to png with
graphviz eg. `dot -Tpng input.dot -o output.png`.
@ppettit
add multistream bin
ced7c51 
captures a v4l2 video stream and pulse audio stream in a single
(mpegts by default) file.
@ppettit
fix exception if recording is paused when ending
cef1bdf 
recorder.current_mediapackage can be None so this makes sure it is
a boolean as required.

fixes teltek#513
@Alfro
Merge pull request teltek#514 from ppettit/513_fix_paused_exception
4c501a0 
fix paused exception
@ppettit
allows setting of pause dialog size in the conf.ini
c9a6292 
our users had trouble with the tiny default pause button. they
often tried to click the disabled transport controls in the bottom
right to unpause and got confused when nothing happened.

to fix this we enlarged the pause button so that it is unmissable!

this adds that feature as a conf option:

```
[basic]
pausedialog_size = 70
```

the value is the percentage of the screen height you would like
the pause dialog to take up. 70 seems good for us.

this also scales the svg correctly to avoid a blurry icon.
@Alfro
CONTRIBUTING: Added CONTRIBUTING guidelines.
9babd8c
@Alfro
Merge pull request teltek#511 from ppettit/dump_dot
48e0e18 
add option to dump dot file of gstreamer pipeline.
@Alfro
Merge branch '2.0.x'
a8ade32
@andiempettJISC
Copy link
Collaborator Author

andiempettJISC commented Nov 16, 2018 •
edited
Loading

I'm sorry, i do realise this is a large pile of code. if more explanation is needed or a demo please let me know.

If it were suggested that this work be done in another way or the plugin made separate from the core code i'd be up for that as a discussion

@ppettit
Copy link
Collaborator

ppettit commented Dec 5, 2018

@androidwiltron I'll get to testing this ASAP, but looks good from a quick glance (and very useful!).

One thing i noticed - is there a particular reason for depending on ffmpeg rather than using the gstreamer concat element?

@andiempettJISC
Copy link
Collaborator Author

@androidwiltron I'll get to testing this ASAP, but looks good from a quick glance (and very useful!).

One thing i noticed - is there a particular reason for depending on ffmpeg rather than using the gstreamer concat element?

really the reason is historical. at the time first written it was gst0.1 still and the stability wasn't 100% and not the best at concatenating certain file types. i think i should look at gst concat again as things have moved on

@Alfro
Merge pull request teltek#597 from cilt-uct/required_minimum_duration…
4837200 
…_for_ingest

Added a configuration parameter to define minimum lenght for recording to be ingested
@Alfro
Copy link
Contributor

Alfro commented Feb 4, 2019

Hi @androidwiltron, do take a look at my colleague comments. I have finally been able to take a look at this and I think we should be able to merge it on master, save a few details.

Sorry for taking so long.

@andiempettJISC
Copy link
Collaborator Author

docs added
teltek/Galicaster-doc#16
teltek/Galicaster-doc#15

@Alfro
Copy link
Contributor

Alfro commented Mar 20, 2019

Hi @androidwiltron

Good work!
Do also remember to check the tests to make sure they're not failing before we merge this to master.

@andiempettJISC
Copy link
Collaborator Author

Hi @androidwiltron

Good work!
Do also remember to check the tests to make sure they're not failing before we merge this to master.

oh yes we have tests these days! let me take a look

andiempettJISC pushed a commit to UoM-Podcast/Galicaster that referenced this pull request Apr 12, 2019
additon to teltek#564 - makes tests work and has a default recovery t…
e06735b 
…ype set in the repository
@Alfro Alfro added feature Use this label for new features or enhancements and removed feature labels Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenrua rubenrua rubenrua left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature Use this label for new features or enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andiempettJISC @ppettit @Alfro @rubenrua @dpeite @rbolrey @corne-oosthuizen