Temporal running locally in a DevContainer #283
+32
−138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I have simplified the devcontainer setup. The previous one (./devcontainer/docker-compose.yml) was out of date with the one in the root of the repo. Rather than use docker-compose we should just use a base go image, install docker and then use the docker-compose.yml that people use that aren't using devcontainers - this way it is consistent.
Why?
Because when you started the DevContainer, the Temporal Server does not start because of a mount issue with the dynamicConfig folder.
Checklist
Closes [Bug] DevContainer doesn't start the temporal server image #282
How was this tested:
make start-local
and check that the images are runningI have added a specific README.md in the .devcontainer folder