-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOMERGE] Rust SDK future proposal draft #550
Draft
Sushisource
wants to merge
3
commits into
temporalio:master
Choose a base branch
from
Sushisource:wf-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
use crate::WfContext; | ||
use futures::future::BoxFuture; | ||
|
||
// #[activity_definition] | ||
type MyActFn = fn(String) -> String; | ||
|
||
// Macro enforces types are serializable. | ||
|
||
// The biggest problem with activity definitions is they need to be defined in a crate which doesn't | ||
// depend on the entire SDK, because then the workflow code which uses them wouldn't be able to | ||
// be compiled down to WASM. Of course, the issue is activities _aren't_ compiled to WASM, and need | ||
// access to full native functionality. Thus users need to structure their app a bit oddly. They | ||
// can either define all their workflow code & activity _definitions_ in one crate, and then | ||
// depend on that crate from another crate containing their activity implementations / worker, or | ||
// they could make a crate with *just* activity definitions, which is depended on by the workflow | ||
// implementation crate and the worker crate independently. It all makes perfect sense, but is | ||
// maybe a bit annoying in terms of setup - though not really any worse than TS. | ||
|
||
// Macro generates this extension & implementation: | ||
// | ||
// The generated code taking `impl Into<Argtype>` is quite nice for ergonomics inside the workflow, | ||
// but might be impossible in some cases, so probably macro would need a flag to turn it off. | ||
pub trait MyActFnWfCtxExt { | ||
// In reality this returns the `CancellableFuture` type from SDK, would also need to move into | ||
// this crate. | ||
fn my_act_fn( | ||
&self, | ||
input: impl Into<String>, | ||
) -> BoxFuture<'static, Result<String, ActivityFail>>; | ||
} | ||
impl MyActFnWfCtxExt for WfContext { | ||
fn my_act_fn(&self, _: impl Into<String>) -> BoxFuture<'static, Result<String, ActivityFail>> { | ||
// Type name is injected in this implementation, taken from macro | ||
todo!() | ||
} | ||
} | ||
|
||
// To implement the activity in their implementation crate, the user would do something like: | ||
// worker.register_activity(MyActFn, |input: String| async move { .... }); | ||
|
||
// Placeholder. Activity failures as can be seen by the WF code. | ||
#[derive(Debug)] | ||
pub struct ActivityFail {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concern here is how to pass in options. One reason that Java's approach of reusing actual activity signature was so rough is that you were forced to make options a separate thing.