feat: fix epoch params #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 66.36% 69.60% +3.23%
==========================================
Files 24 25 +1
Lines 2224 2260 +36
==========================================
+ Hits 1476 1573 +97
+ Misses 608 534 -74
- Partials 140 153 +13
Continue to review full report at Codecov.
|
|
#98 just merged, so It would be better to merge master first |
…96-fix-epoch-params
…96-fix-epoch-params * commit '600c2cc0597050f283a10a0128d9d56c9f7bb671': fix: add exception logic to unpack for unregistered case fix: remove deprecated PlansByFarmer index
dongsam
suggested changes
Sep 16, 2021
hallazzang
suggested changes
Sep 16, 2021
…96-fix-epoch-params # Conflicts: # proto/tendermint/farming/v1beta1/query.proto # x/farming/keeper/grpc_query.go # x/farming/types/farming.pb.go # x/farming/types/query.pb.go # x/farming/types/query.pb.gw.go
…96-fix-epoch-params # Conflicts: # proto/tendermint/farming/v1beta1/genesis.proto # x/farming/client/cli/query.go # x/farming/keeper/epoch_test.go # x/farming/keeper/genesis.go # x/farming/keeper/keeper_test.go # x/farming/types/farming.pb.go # x/farming/types/genesis.go # x/farming/types/genesis.pb.go
jaybxyz
added a commit
to jaybxyz/farming
that referenced
this pull request
Sep 17, 2021
* master: feat: add budget module on simapp (tendermint#118) feat: fix epoch params (tendermint#103) chore: fix typo test: add TestOutstandingRewards style: sort imports feat: add AdvanceEpoch message and tx cli endpoint feat: add cli query commands test: write test for Rewards query endpoint test: write test for TotalStaking query endpoint test: write test for Staking query endpoint feat: implement new query endpoints docs: update spec document fix: include OutstandingRewards in genesis fix: fix epoch advancing criteria fix: use sdk.DecCoins for rewards fix: set total staking on InitGenesis and use helper methods feat: add OutstandingRewards chore: remove unnecessary validation from InitGenesis fix: fix InitGenesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is implemented by following the approach 1 (See the issue #96).
It adds
CurrentEpochDaysglobal parameter for key store prefix and use it inEndBlockerto handle reward distribution.closes: #96
Tasks
EpochDaystoNextEpochDaysin params and fix logics related to itAdditional works
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes