Add public and private plan creation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: update querier and msg server logic fix query service to reflect updated spec; WIP
- update proposal proto messages
* master: Fix core logic (tendermint#15) refactoring for RemoveStakingCoinDenomIndex fix name to workflows apply suggested issues from code review Add kv indexing and iterator functions # Conflicts: # x/farming/keeper/msg_server.go # x/farming/keeper/plan.go # x/farming/types/farming.pb.go # x/farming/types/plan.go
* master: Add farming fee collector (tendermint#22) Update CLI tx commands and fix bugs (tendermint#23) # Conflicts: # x/farming/types/farming.pb.go
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 36.87% 30.48% -6.39%
==========================================
Files 23 26 +3
Lines 1413 1801 +388
==========================================
+ Hits 521 549 +28
- Misses 846 1190 +344
- Partials 46 62 +16
Continue to review full report at Codecov.
|
jaybxyz
changed the title
dongsam
suggested changes
Jul 27, 2021
There was a problem hiding this comment.
Could you add validation functions for PublicPlans with AddRequestProposal, AddRequestProposal, DeleteRequestProposal
and test codes for HandlePublicPlanProposal, AddPublicPlanProposal,
UpdatePublicPlanProposal,
DeletePublicPlanProposal
If the PR is likely to be too long, we can just do structural modifications and continue the rest from other PRs.
…creating more than one plan type
…roposal, DeleteRequestProposal
…estProposal, DeleteRequestProposal
…th the same account
hallazzang
suggested changes
Jul 30, 2021
* master: bump sdk version to v0.43.0-rc2 Implement reward distribution (tendermint#25) Add issue, pr templates # Conflicts: # x/farming/keeper/msg_server.go # x/farming/keeper/plan.go # x/farming/keeper/plan_test.go # x/farming/keeper/proposal_handler.go # x/farming/types/errors.go # x/farming/types/plan.go
dongsam
reviewed
Jul 30, 2021
…add-public-plan * commit '639a96bb38ab9bda41ab15cc74534f520bf4302b': Add pre-commit hook and corresponding doc (tendermint#37)
- add validation logic for ratio plans - add test codes for the validation - clean up error messages
dongsam
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a functionality to create public and private farming plans.
How to test this functionality
In order to test this functionality, I created a gist that contains sample json structure for different types of plans and useful CLI commands and REST APIs in here.
closes: #1