Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add and refactor invariant checks #186

Merged
merged 6 commits into from
Oct 28, 2021

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Oct 21, 2021

Description

closes: #171

Tasks

Add(or refactor) following invariant checks:

  • PositiveStakingAmountInvariant
  • StakingReserveAmountInvariant
  • RemainingRewardsAmountInvariant
  • NonNegativeOutstandingRewardsInvariant
  • OutstandingRewardsAmountInvariant
  • NonNegativeHistoricalRewardsInvariant
  • PositiveTotalStakingsAmountInvariant
  • PlanTerminationStatusInvariant

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

- NonNegativeOutstandingRewardsInvariant
- OutstandingRewardsAmountInvariant
@hallazzang hallazzang self-assigned this Oct 21, 2021
- PositiveStakingAmountInvariant
- NonNegativeHistoricalRewardsInvariant
- PositiveTotalStakingsAmountInvariant
- PlanTerminationStatusInvariant
@hallazzang hallazzang marked this pull request as ready for review October 27, 2021 12:20
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hallazzang hallazzang merged commit 31fe858 into tendermint:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve invariant checks and tests
3 participants