fix modify bid simulation

tendermint · Aug 22, 2024 · d6359d4 · d6359d4
1 parent 91f0ab4
commit d6359d4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/docs/static/openapi.yml b/docs/static/openapi.yml
diff --git a/x/fundraising/simulation/modify_bid.go b/x/fundraising/simulation/modify_bid.go
@@ -1,6 +1,7 @@
 package simulation
 
 import (
+	"fmt"
 	"math/rand"
 
 	"cosmossdk.io/math"
@@ -33,14 +34,11 @@ func SimulateMsgModifyBid(
 
 		// Select a random auction
 		auction := auctions[r.Intn(len(auctions))]
-		if auction.GetStatus() != types.AuctionStatusStarted {
-			return simtypes.NoOpMsg(types.ModuleName, msg.Type(), "auction must be started status"), nil, nil
-		}
 		if auction.GetType() != types.AuctionTypeBatch || auction.GetStatus() != types.AuctionStatusStarted {
-			return simtypes.NoOpMsg(types.ModuleName, msg.Type(), "incorrect auction type or status"), nil, nil
+			return simtypes.NoOpMsg(types.ModuleName, msg.Type(), fmt.Sprintf("incorrect auction type or status %v", auction)), nil, nil
 		}
 
-		bids, err := k.Bids(ctx)
+		bids, err := k.GetBidsByAuctionId(ctx, auction.GetId())
 		if err != nil {
 			return simtypes.NoOpMsg(types.ModuleName, msg.Type(), "failed to get bids"), nil, nil
 		}
@@ -56,7 +54,7 @@ func SimulateMsgModifyBid(
 		spendable := bk.SpendableCoins(ctx, account.GetAddress())
 
 		msg = types.NewMsgModifyBid(
-			auction.GetId(),
+			bid.AuctionId,
 			account.GetAddress().String(),
 			bid.Id,
 			bid.Price,

diff --git a/x/fundraising/simulation/place_bid.go b/x/fundraising/simulation/place_bid.go
@@ -89,7 +89,7 @@ func SimulateMsgPlaceBid(
 
 		newAllowedBidder := types.NewAllowedBidder(auction.GetId(), bidder, maxBidAmt)
 		if err := k.AddAllowedBidders(ctx, auction.GetId(), []types.AllowedBidder{newAllowedBidder}); err != nil {
-			return simtypes.NoOpMsg(types.ModuleName, msg.Type(), "failed to add allowed bidders"), nil, nil
+			return simtypes.NoOpMsg(types.ModuleName, msg.Type(), "failed to add allowed bidders"), nil, err
 		}
 
 		msg = types.NewMsgPlaceBid(