feat: bump cosmos-sdk to v0.50.8 and ignite to v28.5.2
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
reviewed
Aug 29, 2024
| @@ -1,7 +1,9 @@ | |||
| # CODEOWNERS: https://help.github.com/articles/about-codeowners/ | |||
|
|
|||
| # Primary repo maintainers | |||
There was a problem hiding this comment.
cc @ilgooz, you need to add a few of us in the repo
Co-authored-by: Jerónimo Albi <[email protected]>
There was a problem hiding this comment.
Would it make sense to move the tests to the corresponding keeper "_test.go" files to then remove the store_test.go?
The store.go file doesn't exist anymore because its code was moved into separate keeper files, so store_test.go seems to be left out of the refactor.
There was a problem hiding this comment.
the store_test.go is also useful to test the other store helper methods, like createFixedPriceAuction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.