Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): remove deprecated rest imports #908

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jul 26, 2022

What does this PR does?

Removes deprecated rest associated imports in app.go. This is to prepare for their being removed in Cosmos SDK v0.46.x.

Part of #909

Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Include tests
  • Respect code style and lint
  • Update documentation (*.md) (if needed)

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #908 (129df05) into develop (d55fd30) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #908   +/-   ##
========================================
  Coverage    10.56%   10.57%           
========================================
  Files          327      327           
  Lines        75110    75110           
========================================
+ Hits          7939     7941    +2     
+ Misses       66982    66981    -1     
+ Partials       189      188    -1     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 84.45% <0.00%> (+1.35%) ⬆️

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's purge rest everywhere

@lumtis lumtis merged commit f1ee1a7 into develop Jul 26, 2022
@lumtis lumtis deleted the refactor/remove-deprecated-rest branch July 26, 2022 15:46
@lumtis lumtis mentioned this pull request Jul 26, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants