Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove usage of ToDec() #910

Merged
merged 1 commit into from
Jul 26, 2022
Merged

refactor: remove usage of ToDec() #910

merged 1 commit into from
Jul 26, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jul 26, 2022

What does this PR does?

Remove all uses of the sdk.Int.ToDec() function. This function is removed in SDK v0.46.0. Conversion between sdk.Int and sdk.Dec can be done using sdk.NewDecFromInt().

Part of #909

Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Include tests
  • Respect code style and lint
  • Update documentation (*.md) (if needed)

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #910 (8e72dab) into develop (f1ee1a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #910   +/-   ##
========================================
  Coverage    10.56%   10.57%           
========================================
  Files          327      327           
  Lines        75110    75110           
========================================
+ Hits          7938     7941    +3     
+ Misses       66983    66981    -2     
+ Partials       189      188    -1     
Impacted Files Coverage Δ
x/claim/types/claim_record.go 100.00% <100.00%> (ø)
x/launch/keeper/genesis_validator.go 100.00% <100.00%> (ø)
x/launch/keeper/validator_set.go 100.00% <100.00%> (ø)
x/participation/keeper/total_allocations.go 100.00% <100.00%> (ø)
x/reward/keeper/reward_distribution.go 80.57% <100.00%> (ø)
x/campaign/simulation/store.go 84.45% <0.00%> (+2.02%) ⬆️

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis merged commit e185661 into develop Jul 26, 2022
@lumtis lumtis deleted the refactor/remove-ToDec branch July 26, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants