Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ignite dep #911

Merged
merged 8 commits into from
Jul 27, 2022
Merged

refactor: remove ignite dep #911

merged 8 commits into from
Jul 27, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jul 26, 2022

What does this PR does?

Removes the ignite dependency from the repository. Importing ignite introduces a set of circular dependencies because:

  • igniteimportsspn`
  • spn imports ignite
  • spn imports x/fundraising
  • x/fundraising imports ignite

This cycle has made upgrading the packages very challenging, so this PR helps alleviate that. The main import was the pkg/cosmsocmd module which has now been added to the local cmd package. This functionality is commonly placed in this local package as can be seen with gaia. The openAPI code has also been removed. This can potentially be added back in later. We should prioritize decoupling from ignite-cli though.

Part of #909

These are the criteria that every PR should meet, please check them off as you
review them:

  • Include tests
  • Respect code style and lint
  • Update documentation (*.md) (if needed)

@aljo242 aljo242 changed the title Refactor/remove ignite dep refactor: remove ignite dep Jul 26, 2022
@aljo242 aljo242 changed the title refactor: remove ignite dep refactor: remove ignite dep Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #911 (ba13221) into develop (f310279) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #911   +/-   ##
========================================
  Coverage    10.56%   10.56%           
========================================
  Files          327      327           
  Lines        75191    75191           
========================================
+ Hits          7942     7944    +2     
+ Misses       67060    67059    -1     
+ Partials       189      188    -1     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 84.45% <0.00%> (+1.35%) ⬆️

lumtis
lumtis previously approved these changes Jul 26, 2022
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/app.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
Co-authored-by: Lucas Btd <[email protected]>
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can run commands, etc...

@lumtis lumtis merged commit c3ff13f into develop Jul 27, 2022
@lumtis lumtis deleted the refactor/remove-ignite-dep branch July 27, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants