Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement btree.item on item itelf, not only its pointer. #254

Merged
merged 4 commits into from
May 19, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions memdb.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ func (i *item) Less(other btree.Item) bool {
return bytes.Compare(i.key, other.(*item).key) == -1
}

// LessDirect implements btree.Item directly on item instead of its pointer.
// Question: is this it, or do we need to get the pointer off of other.(*item).key?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the question

func (i item) LessDirect(other btree.Item) bool {
// this considers nil == []byte{}, but that's ok since we handle nil endpoints
// in iterators specially anyway
return bytes.Compare(i.key, other.(*item).key) == -1
}

// newKey creates a new key item.
func newKey(key []byte) *item {
return &item{key: key}
Expand Down