Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: long overdue refactor #359

Closed
wants to merge 123 commits into from
Closed

fix: long overdue refactor #359

wants to merge 123 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Feb 21, 2024

This is prepared for pebble support in Celestia without breaking changes

thanethomson and others added 30 commits December 23, 2022 11:33
@thanethomson
Update CODEOWNERS
e8ceb31 
Signed-off-by: Thane Thomson <[email protected]>
@thanethomson
Update dependabot config
104c763 
Signed-off-by: Thane Thomson <[email protected]>
@thanethomson
Update workflows to reference main instead of master
fc4d585 
Signed-off-by: Thane Thomson <[email protected]>
@thanethomson
Update release guidelines to reference main
33ef5c0 
Signed-off-by: Thane Thomson <[email protected]>
@thanethomson @faddat
Temporarily revert v0.6.7 changes (tendermint#9)
56cf362 
* Revert "Remove @creachadair from the CODEOWNERS file. (tendermint#285)"

This reverts commit 0c9484c.

* Revert all changes since v0.6.6

Signed-off-by: Thane Thomson <[email protected]>

* make format

Signed-off-by: Thane Thomson <[email protected]>

* Address linter complaints

Signed-off-by: Thane Thomson <[email protected]>

* Remove deprecated io/ioutil usage

Signed-off-by: Thane Thomson <[email protected]>

* Use latest GitHub workflows

Signed-off-by: Thane Thomson <[email protected]>

* regenerate certs (tendermint#280)

* Disable CI failure if coverage upload fails

Signed-off-by: Thane Thomson <[email protected]>

* Remove redundant Printf/Println statements/comments

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: Jacob Gadikian <[email protected]>
@thanethomson
Rename Go package (tendermint#14)
28d45f7 
* Rename package

Signed-off-by: Thane Thomson <[email protected]>

* Update and rename Makefile to match convention

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@thanethomson
Rename package to lowercase cometbft (tendermint#16)
e9ad98a 
* Lowercase repo and org names in package

Signed-off-by: Thane Thomson <[email protected]>

* Regenerate certs with cometbft.com domain

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@thanethomson
ci: Update Docker test image build workflow (tendermint#17)
ecfbde5
@dependabot
build(deps): bump github.com/stretchr/testify from 1.8.0 to 1.8.1 (te…
ba69263 
…ndermint#5)
@dependabot
build(deps): bump github.com/dgraph-io/badger/v2 (tendermint#19)
a5ac542 
Bumps [github.com/dgraph-io/badger/v2](https://github.com/dgraph-io/badger) from 2.2007.2 to 2.2007.4.
- [Release notes](https://github.com/dgraph-io/badger/releases)
- [Changelog](https://github.com/dgraph-io/badger/blob/main/CHANGELOG.md)
- [Commits](dgraph-io/badger@v2.2007.2...v2.2007.4)

---
updated-dependencies:
- dependency-name: github.com/dgraph-io/badger/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@thanethomson
ci: Update workflows to use cometbft/cometbft-db-testing image (ten…
6b31fc6 
…dermint#20)

* ci: Update workflows to use cometbft/cometbft-db-testing image

Signed-off-by: Thane Thomson <[email protected]>

* Add version "v" prefix to golangci-lint in action config

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@dependabot
build(deps): bump actions/stale from 5 to 7 (tendermint#1)
b7ce76c 
Bumps [actions/stale](https://github.com/actions/stale) from 5 to 7.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v5...v7)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump golangci/golangci-lint-action from 3.2.0 to 3.3.1 (t…
478e411 
…endermint#2)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.2.0 to 3.3.1.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.2.0...v3.3.1)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump google.golang.org/grpc from 1.50.1 to 1.52.0 (tende…
4aba9c0 
…rmint#6)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.1 to 1.52.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.50.1...v1.52.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump github.com/google/btree from 1.0.0 to 1.1.2 (tender…
39cc55b 
…mint#18)

Bumps [github.com/google/btree](https://github.com/google/btree) from 1.0.0 to 1.1.2.
- [Release notes](https://github.com/google/btree/releases)
- [Commits](google/btree@v1.0.0...v1.1.2)

---
updated-dependencies:
- dependency-name: github.com/google/btree
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@thanethomson
Add local version of CI test (tendermint#22)
ae20f38 
* Add local version of CI test

Signed-off-by: Thane Thomson <[email protected]>

* Remove unnecessary env var config

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@thanethomson
Update Go version to 1.18 (tendermint#24)
5b5e7ff 
* Update Go version to 1.18

Signed-off-by: Thane Thomson <[email protected]>

* Update readme to reflect minimum Go version

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@thanethomson
ci: Sync workflows with CometBFT (tendermint#25)
1dc5853 
* Add govulncheck

Signed-off-by: Thane Thomson <[email protected]>

* Sync stalebot config with cometbft

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@lasarojc @thanethomson
Enabling manual creation of CHANGELOG.md with unclog (tendermint#21)
ef2a688 
* Enabling manual creation of CHANGELOG.md with unclog

* Update .changelog/epilogue.md

Co-authored-by: Thane Thomson <[email protected]>

* Delete entry for reverted commit

Co-authored-by: Thane Thomson <[email protected]>
@thanethomson
deps: Replace tecbot/gorocksdb with cosmos/gorocksdb (tendermint#27)
110d46f 
Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@thanethomson
Revert cosmos/gorocksdb dependency update (tendermint#28)
2f2cde9 
Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@thanethomson @sergio-mena
docs: Rename to CometBFT (tendermint#26)
0dd0299 
* docs: Update README

Signed-off-by: Thane Thomson <[email protected]>

* docs: Update contributing guidelines

Signed-off-by: Thane Thomson <[email protected]>

* docs: Replace how_to_release doc with RELEASES in repo root

Signed-off-by: Thane Thomson <[email protected]>

* Remove dead links from code

Signed-off-by: Thane Thomson <[email protected]>

* Use standard Apache 2.0 license

Signed-off-by: Thane Thomson <[email protected]>

* Apply suggestions from code review

Co-authored-by: Sergio Mena <[email protected]>

* docs: Add fork notice to readme

Signed-off-by: Thane Thomson <[email protected]>

* docs: Reshuffle some links

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: Sergio Mena <[email protected]>
@thanethomson
Release v0.7.0 (tendermint#29)
25056d0 
* Prepare changelog for v0.7.0

Signed-off-by: Thane Thomson <[email protected]>

* Build changelog

Signed-off-by: Thane Thomson <[email protected]>

* Add hrule to top of epilogue to separate changelog from epilogue

Signed-off-by: Thane Thomson <[email protected]>

* Manually escape issue number

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@dependabot
build(deps): bump google.golang.org/grpc from 1.52.0 to 1.52.1 (tende…
5eb13a4 
…rmint#31)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.52.0 to 1.52.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.52.0...v1.52.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (t…
bb56d94 
…endermint#30)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump google.golang.org/grpc from 1.52.1 to 1.52.3 (tende…
985738b 
…rmint#32)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.52.1 to 1.52.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.52.1...v1.52.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@thanethomson
ci: Re-enable code coverage failure check (tendermint#36)
a188a99 
Signed-off-by: Thane Thomson <[email protected]>
@dependabot
build(deps): bump docker/build-push-action from 3 to 4 (tendermint#34)
2c3355f 
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v3...v4)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump google.golang.org/grpc from 1.52.3 to 1.53.0 (tende…
6a5cda6 
…rmint#38)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.52.3 to 1.53.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.52.3...v1.53.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump go.etcd.io/bbolt from 1.3.6 to 1.3.7 (tendermint#35)
8e4d119 
Bumps [go.etcd.io/bbolt](https://github.com/etcd-io/bbolt) from 1.3.6 to 1.3.7.
- [Release notes](https://github.com/etcd-io/bbolt/releases)
- [Commits](etcd-io/bbolt@v1.3.6...v1.3.7)

---
updated-dependencies:
- dependency-name: go.etcd.io/bbolt
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
faddat added 19 commits February 15, 2024 15:56
@faddat
use Dockerfile for the linter same as we do for tests
02faef3
@faddat
remove unused databses.
905c8ba
@faddat
both cometbft-db and cometbft no longer need convoluted docker setups
afaa74f
@faddat
remove the build tags from pebble
4558892
@faddat
no longer need to run the linter in Docker
25d25ca
@faddat
change the "ci" action
c85030e
@faddat
lint
b420fc4
@faddat
add tests for pebble
7db5d19
@faddat
lint
ea8b555
@faddat
remove docker.yml from github actions
f2e95c6
@faddat
enhance pebble tests
a4cc91a
@faddat
make the pebble iterator tests match the goleveldb iterator tests
03fc996
@faddat
run govulncheck all the time, fix yaml lint issues in stale.yml
56a2845
@faddat
give pebble stats
2aa29ce
@faddat
tweak goleveldb
5082e30
@faddat
don't make .db a constant
f9b6458
@faddat
Update README.md
86ebdb9
@faddat
change module path so celestia can use this
307fc9b
@faddat
Merge branch 'faddat/bump-go-and-pebble' of https://github.com/faddat…
fc0fbd3 
…/cometbft-db into faddat/bump-go-and-pebble
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.70130% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 74.94%. Comparing base (774cdfe) to head (fc0fbd3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   68.30%   74.94%   +6.63%     
==========================================
  Files          27       13      -14     
  Lines        2073      930    -1143     
==========================================
- Hits         1416      697     -719     
+ Misses        586      190     -396     
+ Partials       71       43      -28
Files Coverage Δ
goleveldb_batch.go 94.44% <ø> (+1.11%) ⬆️
prefixdb.go 71.30% <100.00%> (+7.74%) ⬆️
prefixdb_iterator.go 81.25% <100.00%> (+0.23%) ⬆️
test_helpers.go 100.00% <100.00%> (ø)
util.go 40.00% <100.00%> (+3.33%) ⬆️
db.go 41.17% <50.00%> (+6.17%) ⬆️
goleveldb.go 65.51% <84.21%> (+6.60%) ⬆️
memdb_iterator.go 91.46% <50.00%> (-1.95%) ⬇️
memdb.go 70.65% <71.42%> (+0.38%) ⬆️
pebble.go 70.71% <70.71%> (ø)

... and 3 files with indirect coverage changes

Files Coverage Δ
goleveldb_batch.go 94.44% <ø> (+1.11%) ⬆️
prefixdb.go 71.30% <100.00%> (+7.74%) ⬆️
prefixdb_iterator.go 81.25% <100.00%> (+0.23%) ⬆️
test_helpers.go 100.00% <100.00%> (ø)
util.go 40.00% <100.00%> (+3.33%) ⬆️
db.go 41.17% <50.00%> (+6.17%) ⬆️
goleveldb.go 65.51% <84.21%> (+6.60%) ⬆️
memdb_iterator.go 91.46% <50.00%> (-1.95%) ⬇️
memdb.go 70.65% <71.42%> (+0.38%) ⬆️
pebble.go 70.71% <70.71%> (ø)

... and 3 files with indirect coverage changes

@faddat faddat mentioned this pull request Feb 22, 2024
Closed
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added Stale and removed Stale labels Mar 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added Stale and removed Stale labels Apr 4, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Apr 26, 2024
@github-actions github-actions bot closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@faddat @thanethomson @lasarojc @greg-szabo @yihuang @melekes @jmalicevic