-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v0.4.0 #615
Merged
Merged
release: v0.4.0 #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? I cannot see. pgvecto.rs/sql/install/vectors--0.3.0.sql Lines 859 to 866 in cc4776f
typmod .
pgvecto.rs/sql/upgrade/vectors--0.2.1--0.3.0.sql Lines 345 to 350 in cc4776f
typmod .
|
usamoi
requested changes
Nov 20, 2024
cutecutecat
force-pushed
the
release-v0.4.0
branch
2 times, most recently
from
November 20, 2024 09:05
cfb5ae4
to
a15aa33
Compare
usamoi
reviewed
Nov 20, 2024
Signed-off-by: cutecutecat <[email protected]>
Signed-off-by: cutecutecat <[email protected]>
cutecutecat
force-pushed
the
release-v0.4.0
branch
from
November 20, 2024 10:48
a15aa33
to
fc21e0c
Compare
usamoi
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update from
0.3.0
to0.4.0
might fail!Due to a conflict definition of
_vectors_svecf32_in
at0.3.0
:and at 0.2.1--0.3.0:
As
0.4.0
picks latter signature, and PostgreSQL doesn't support parameter name changing.Therefore the update route of
0.2.1 -> 0.3.0 -> 0.4.0
can succeed, but0.3.0 -> 0.4.0
would fail.Ref: L744 of file
sql/upgrade/vectors--0.3.0--0.4.0.sql
Conclusion
Check and Keep these two signatures as their own.