Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.4.0 #615

Merged
merged 2 commits into from
Nov 20, 2024
Merged

release: v0.4.0 #615

merged 2 commits into from
Nov 20, 2024

Conversation

cutecutecat
Copy link
Member

@cutecutecat cutecutecat commented Nov 19, 2024

The update from 0.3.0 to 0.4.0 might fail!

Due to a conflict definition of _vectors_svecf32_in at 0.3.0:

_vectors_svecf32_in(input, oid, _typmod)

and at 0.2.1--0.3.0:

_vectors_svecf32_in(input, oid, typmod)

As 0.4.0 picks latter signature, and PostgreSQL doesn't support parameter name changing.

Therefore the update route of 0.2.1 -> 0.3.0 -> 0.4.0 can succeed, but 0.3.0 -> 0.4.0 would fail.

Ref: L744 of file sql/upgrade/vectors--0.3.0--0.4.0.sql

Conclusion

Check and Keep these two signatures as their own.

@usamoi
Copy link
Collaborator

usamoi commented Nov 20, 2024

Due to a conflict definition of _vectors_svecf32_in at 0.3.0:

Why? I cannot see.

CREATE FUNCTION "_vectors_svecf32_in"(
"input" cstring, /* &core::ffi::c_str::CStr */
"_oid" oid, /* pgrx_pg_sys::submodules::oids::Oid */
"typmod" INT /* i32 */
) RETURNS svector /* vectors::datatype::memory_svecf32::SVecf32Output */
IMMUTABLE STRICT PARALLEL SAFE
LANGUAGE c /* Rust */
AS 'MODULE_PATHNAME', '_vectors_svecf32_in_wrapper';
. The parameter name is typmod.

CREATE FUNCTION "_vectors_svecf32_in"(
"input" cstring,
"_oid" oid,
"typmod" INT
) RETURNS svector
IMMUTABLE STRICT PARALLEL SAFE LANGUAGE c AS 'MODULE_PATHNAME', '_vectors_svecf32_in_wrapper';
. The parameter name is typmod.

@cutecutecat cutecutecat force-pushed the release-v0.4.0 branch 2 times, most recently from cfb5ae4 to a15aa33 Compare November 20, 2024 09:05
@cutecutecat cutecutecat requested a review from usamoi November 20, 2024 09:17
Signed-off-by: cutecutecat <[email protected]>
Signed-off-by: cutecutecat <[email protected]>
@cutecutecat cutecutecat added this pull request to the merge queue Nov 20, 2024
Merged via the queue into tensorchord:main with commit 21656e4 Nov 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants