Loading text tutorial: removed +1 from VOCAB_SIZE+1 #2261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Beginners tutorials > Load and preprocess data > Text, under the "Download more datasets using TensorFlow Datasets (TFDS)" section, we do:
Since the vocabulary of the
TextVectorization
layer already includes both the padding token and OOV token (i.e. the maximum index possible is 9999 when VOCAB_SIZE is 10000), I believe the +1 should be removed fromVOCAB_SIZE + 1
. TheEmbedding
layer created bycreate_model
should not see a token with a value greater than 9999.