Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the tf issue #74564 #2322

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

sanskarmodi8
Copy link
Contributor

I looked into the issue and found out that after the evaluation we are getting a list of size 4 where only the last one is the accuracy of the export_model. So ignored all the other output to only get the required loss and accuracy

I looked into the issue and found out that after the evaluation we are getting a list of size 4 where only the last one is the accuracy of the export_model. So ignored all the other output to only get the required loss and accuracy
@sanskarmodi8 sanskarmodi8 requested a review from a team as a code owner August 28, 2024 12:13
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin fix-tf-issue-74564

Use `return_dict=True` for evaluate.
@MarkDaoust MarkDaoust added the ready to pull Start merge process label Aug 29, 2024
@MarkDaoust
Copy link
Member

Thanks for the fix!

I actually always prefer return_dict=True because then the response labels each output. It makes it much clearer what's what.

@copybara-service copybara-service bot merged commit 3d45463 into tensorflow:master Aug 30, 2024
5 checks passed
@sanskarmodi8
Copy link
Contributor Author

Thanks for the fix!

I actually always prefer return_dict=True because then the response labels each output. It makes it much clearer what's what.

Thank you, Mark! I'll keep that in mind and make sure to use return_dict=True moving forward.
It definitely helps in making the output clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants