Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tensorflow issue https://github.com/tensorflow/tensorflow/issues/75194 #2325

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

sanskarmodi8
Copy link
Contributor

@sanskarmodi8 sanskarmodi8 commented Sep 8, 2024

Edited the compile_and_fit method in the overfit_and_underfit.ipynb notebook to correctly pass the train and val data to avoid shape mismatch error.

@sanskarmodi8 sanskarmodi8 requested a review from a team as a code owner September 8, 2024 13:16
Copy link

github-actions bot commented Sep 8, 2024

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin issue#75194-fix

@sanskarmodi8 sanskarmodi8 changed the title Issue#75194 fix fixed tensorflow issue https://github.com/tensorflow/tensorflow/issues/75194 Sep 8, 2024
@sanskarmodi8
Copy link
Contributor Author

Are there any updates on this?

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it looks like this PR includes your changes from #2324.

Can you git rebase -i master to remove that commit and then git push -f to remove it from this PR?

At the same time can you remove outputs from the notebook?

@sanskarmodi8
Copy link
Contributor Author

sanskarmodi8 commented Sep 11, 2024

Hi, it looks like this PR includes your changes from #2324.

Can you git rebase -i master to remove that commit and then git push -f to remove it from this PR?

At the same time can you remove outputs from the notebook?

I have done the changes accordingly and pushed.

@sanskarmodi8
Copy link
Contributor Author

Hey @MarkDaoust ,
Any updates on this?
I have removed changes from #2324

@MarkDaoust MarkDaoust added the ready to pull Start merge process label Sep 13, 2024
@copybara-service copybara-service bot merged commit c841a6e into tensorflow:master Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants