Update package.json to resolve #8186 #8256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfjs v4.0+ solves issue tensorflow#6922 which caused it to not be usable in web workers. tfjs-automl still used v3.9.0 . This fork updates it to 4.9.0+ , same as in its devDependencies.
Updated the version of the tfjs-core dependency in tfjs-automl to resolve the ReferenceError when run from within a web worker.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
pyu10055
reviewed
May 30, 2024
| @@ -60,6 +60,6 @@ | |||
| "peerDependencies": { | |||
| "@tensorflow/tfjs-backend-webgl": "^3.9.0", | |||
| "@tensorflow/tfjs-converter": "^3.9.0", | |||
| "@tensorflow/tfjs-core": "^3.9.0" | |||
There was a problem hiding this comment.
please update all packages to the same version. thanks
There was a problem hiding this comment.
Thanks for reviewing the PR @pyu10055 . I've updated all dependency versions to the latest release 4.19.0 . Ran the tests locally and they all passed.
There was a problem hiding this comment.
Please review again when you can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the version of the tfjs-core dependency in tfjs-automl to resolve the ReferenceError when run from within a web worker. More info in #8186 .
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.