Ncvetkovic/15326 exceeding core grid fail #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncvetkovicTT
force-pushed
the
ncvetkovic/15326-exceeding_core_grid_fail
branch
from
baa93c7 to
fa1843a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
tt-metal#15326
Problem description
Several tt-metal issues have a similar underlying problem that when an input tensor is of size NCHW, where N*C > core_grid, the tests fail.
What's changed:
When there are multiple blocks to be computed by a single core, Z counter in PACK has to be properly set/reset. This PR adds Z counter reset in pack_untilize.