Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15744: Emable FP32 for Reduce Scalar #54

Merged
merged 1 commit into from
Dec 5, 2024
Merged

#15744: Emable FP32 for Reduce Scalar #54

merged 1 commit into from
Dec 5, 2024

Conversation

ncvetkovicTT
Copy link
Contributor

Enabler PR for #15744 - we can remove assert for reduce scalar the same way it's done for Wormhole. I have temporarily enabled TensixComputeReduceHWShortInit and the test passes:

[ RUN      ] DeviceFixture.TensixComputeReduceHWShortInit
                 Device | INFO     | Opening user mode device driver
  Detecting chips (found 1)                                                                                                                                                                                                                                                                                                                                                                                                                     
2024-12-05 17:41:48.901 | WARNING  | SiliconDriver   - Unknown board type for chip 0. This might happen because chip is running old firmware. Defaulting to DEFAULT
2024-12-05 17:41:48.901 | WARNING  | SiliconDriver   - Unknown board type for chip 0. This might happen because chip is running old firmware. Defaulting to DEFAULT
2024-12-05 17:41:48.902 | INFO     | SiliconDriver   - Detected 1 PCI device : [0]
2024-12-05 17:41:48.902 | INFO     | SiliconDriver   - Opened PCI device 0; KMD version: 1.29.0
                  Metal | INFO     | Initializing device 0. Program cache is NOT enabled
                 Device | INFO     | For Blackhole hardcode AICLK to 800 MHz due to lack of ARC message support
                  Metal | INFO     | AI CLK for device 0 is:   800 MHz
                 Always | WARNING  | Dispatch Core Type = CoreType::WORKER
                  Metal | INFO     | DPRINT enabled on device 0, worker core (x=0,y=0) (physical (x=1,y=2)).
                  Metal | INFO     | DPRINT Server attached device 0
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = LoFi, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi2, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi3, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::SUM, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::SUM, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::AVG, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::AVG, FP32DestAcc = false, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::MAX, FP32DestAcc = true, DstSyncFull = false, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = true, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = true, at_start = false
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = false, at_start = true
                   Test | INFO     | MathFid = HiFi4, ReduceType = ReduceType::MAX, FP32DestAcc = false, DstSyncFull = false, at_start = false
                  Metal | INFO     | Closing device 0
                  Metal | INFO     | DPRINT Server dettached device 0
                  Metal | INFO     | Disabling and clearing program cache on device 0
[       OK ] DeviceFixture.TensixComputeReduceHWShortInit (19857 ms)
[----------] 1 test from DeviceFixture (19857 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (19857 ms total)
[  PASSED  ] 1 test.

@ncvetkovicTT ncvetkovicTT changed the title #14352: Check whether to ZEROACC F0/F1 in ELWMUL COL #15744: Emable FP32 for Reduce Scalar Dec 5, 2024
@ncvetkovicTT ncvetkovicTT force-pushed the ncvetkovic/15744_enable_fp32_reduce_scalar branch from d7d1c67 to 2d18669 Compare December 5, 2024 17:51
@ncvetkovicTT ncvetkovicTT merged commit 5686dd5 into main Dec 5, 2024
1 check passed
@ncvetkovicTT ncvetkovicTT mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvelickovicTT nvelickovicTT nvelickovicTT approved these changes

@ttmtrajkovic ttmtrajkovic Awaiting requested review from ttmtrajkovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncvetkovicTT @nvelickovicTT