#13901: Wide Reductions with Non-8-Tile Multiples #16251
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
MaxPool2D should support wide reductions with non-max tile multiple C dimensions. This PR implements this feature for non-large kernels.
What's changed
The number of C tiles has been adjusted to use ceiling instead of a normal divide. The reader kernel has been updated to read either the max bytes per reduction, or a small remainder. The compute kernel has been updated to process max tile multiples for the first N-1 blocks, followed by a smaller number of tiles for the last block.
Currently large kernels will not work with non-max tile multiples so test skips have also been added to bypass these combinations with the new non-multiple test cases.
Checklist