Support three ^r152 color space #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoHamuy
changed the title
|
Hello Please remove any build related code from the PR. The build will be later built and published |
This reverts commit 7998af5.
|
@tentone , done :) |
|
@tentone build seems to fail under Node 12. I can reproduce this from |
|
Thank you code looks good! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
Has backward compatibility with older threeJS versions too.
Followed the migration guides:
How to test: Install
threer151 or r152. Look at any map.Before: From r152, colours were washed out.
Now: Both should look identical.