-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Density matrix class and simulation #324
base: devel
Are you sure you want to change the base?
Conversation
updates from devel
Looks good! |
Hi Jakob, sorry got a bit caught up, I'm working on some test cases for the
Expected Output:
I do have to note that we'd still need to modify for the other backends to allow for density simulation or flag otherwise. |
@@ -176,9 +176,9 @@ def pick_backend(backend: str = None, samples: int = None, noise: NoiseModel = N | |||
for f in INSTALLED_SAMPLERS.keys(): | |||
return f | |||
else: | |||
if samples is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will lead to too many clashes with other applications.
return type of tq.simulate(circuit) is not clear from context anymore (wavefunction or density matrix)
Propose the following: Add simulate_density_matrix method. Within the method, check backend and only allow qiskit (because the simulation is not supported for others currently, as far as I understand).
Hi, Praveen, I am just following up on this (no time pressure, though). |
Hey Jakob, thanks for following up! Been a bit lazy on this, I'll get this done asap. |
No worries, there is no time pressure. I just wanted to check if there are problems or if some of the comments are unclear. |
Hi Jakob, apologies for the delay again. My branch is a bit out-dated with main, will deal with the merge later. I've been looking into adding in density simulation and had a couple of questions, I've added a
|
Hi Praveen, |
Thanks for the flow chart! Will let you know if any questions and hopefully wrap his up soon. |
Thought it would be useful for density simulation to allow for noise. Right now only Qiskit backend, would require to modify other backend simulator files. I'm not sure if I did the pull request right, see commit with ID f378f16