Correctly handle empty target value (e.g. for temporary records)

terminal42 · Jun 18, 2024 · 77710b2 · 77710b2
1 parent 8998afa
commit 77710b2
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/EventListener/DataContainer/ShortlinkLabelListener.php b/src/EventListener/DataContainer/ShortlinkLabelListener.php
@@ -39,12 +39,14 @@ public function __invoke(array $row, string $label, DataContainer $dc, array $co
                     break;
 
                 case 'target':
-                    $targetUrl = $this->generator->generateTargetUrl($row['target']);
-                    $columns[$k] = sprintf(
-                        '<a href="%s" target="_blank">%s</a>',
-                        $targetUrl,
-                        $row['name'] ?: $targetUrl,
-                    );
+                    if ($row['target']) {
+                        $targetUrl = $this->generator->generateTargetUrl($row['target']);
+                        $columns[$k] = sprintf(
+                            '<a href="%s" target="_blank">%s</a>',
+                            $targetUrl,
+                            $row['name'] ?: $targetUrl,
+                        );
+                    }
                     break;
 
                 case 'log':