Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Defer to user-supplied input before disabling execute-api endpoint #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dgholz
Copy link

@dgholz dgholz commented Dec 12, 2024

Description

Allow users to leave the default endpoint enabled when a custom domain is set.

Motivation and Context

Setting the disable_execute_api_endpoint variable to false should leave the default endpoint enabled when a custom domain is set.
This change resolves #128
This change also preserves the existing behaviour of disabling the default endpoint when a custom domain is set & no value was given for the disable_execute_api_endpoint variable.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have used this change in my own Terraform module to see that the default endpoint was not disabled
  • I have executed pre-commit run -a on my pull request

@dgholz
Copy link
Author

dgholz commented Dec 12, 2024

I'm happy to add an example to cover this behaviour, but would appreciate some guidance on where to put it & what to include.

@dgholz dgholz changed the title Defer to user-supplied input before disabling execute-api endpoint fix: defer to user-supplied input before disabling execute-api endpoint Dec 12, 2024
@dgholz dgholz changed the title fix: defer to user-supplied input before disabling execute-api endpoint fix: Defer to user-supplied input before disabling execute-api endpoint Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set disable_execute_api_endpoint to False doesn't Work
1 participant