Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add variable for applying tags to the log_forwarder bucket #41

Merged

Conversation

ch1aki
Copy link
Contributor

@ch1aki ch1aki commented Aug 27, 2024

Description

Add a bucket_tag variable to modules/log_forwarder to allow tagging only the bucket.

Motivation and Context

We are using bucket tags for operational metadata and control of detection in AWS Config, therefore, we want to be able to add arbitrary bucket tags.

Breaking Changes

None. This update does not break backwards compatibility with the current major version.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit 37701a0 into terraform-aws-modules:master Aug 28, 2024
10 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 28, 2024
## [6.1.0](v6.0.2...v6.1.0) (2024-08-28)

### Features

* Add variable for applying tags to the log_forwarder bucket ([#41](#41)) ([37701a0](37701a0))
@antonbabenko
Copy link
Member

This PR is included in version 6.1.0 🎉

@ch1aki ch1aki deleted the add-bucket-tag-param branch August 28, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants