fix: Add conditional to access IAM role when used as fallback value #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson1022
changed the title
mrobinson1022
changed the title
mrobinson1022
changed the title
mrobinson1022
changed the title
|
Thanks for fixing this, this issue has been blocking upgrading the module reference in existing deployments. Any chance for someone to review this PR? |
|
@bryantbiggs Let me know if you need anything to merge this PR, thanks! |
bryantbiggs
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Oct 27, 2023
### [2.0.1](v2.0.0...v2.0.1) (2023-10-27) ### Bug Fixes * Add conditional to access IAM role when used as fallback value ([#48](#48)) ([3695079](3695079))
|
This PR is included in version 2.0.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a ternary on create_access_iam_role on lookups for
service_access_role_arnin aws_dms_endpoint.this.kinesis settings,secrets_manager_access_role_arnandservice_access_rolein aws_dms_endpoint.this. I did not add the ternary to the elasticsearch block as the role is required in that context. However, using an already defined role will likely cause a failure here for the same reason, but I did not test this scenario as I am not using elasticsearch with DMS.Motivation and Context
Implementations of the module where roles have already been provisioned for access and are passed to the necessary objects resulted in a failure when
create_access_iam_role = falsedue toaws_iam_role.access[0].arnis an empty tuple.Breaking Changes
This should not introduce any breaking changes.
How Has This Been Tested?
No changes. Your infrastructure matches the configuration.pre-commit run -aon my pull request