generated from clowdhaus/terraform-aws-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for aws_ecr_repository_creation_template #45
Closed
jakubmatyszewski
wants to merge
1
commit into
terraform-aws-modules:master
from
jakubmatyszewski:aws_ecr_repository_creation_template
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ terraform { | |
required_providers { | ||
aws = { | ||
source = "hashicorp/aws" | ||
version = ">= 5.37" | ||
version = ">= 5.61" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -197,3 +197,67 @@ variable "registry_replication_rules" { | |||||
type = any | ||||||
default = [] | ||||||
} | ||||||
|
||||||
################################################################################ | ||||||
# Repository Creation Template | ||||||
################################################################################ | ||||||
|
||||||
variable "create_repository_creation_template" { | ||||||
description = "Determines whether a repository creation template will be created" | ||||||
type = bool | ||||||
default = false | ||||||
} | ||||||
|
||||||
variable "repository_creation_template_prefix" { | ||||||
description = "The repository name prefix to match against. Use ROOT to match any prefix that doesn't explicitly match another template." | ||||||
type = string | ||||||
default = null | ||||||
} | ||||||
|
||||||
variable "repository_creation_template_applied_for" { | ||||||
description = "Which features this template applies to. Must contain one or more of PULL_THROUGH_CACHE or REPLICATION." | ||||||
type = list(string) | ||||||
default = ["PULL_THROUGH_CACHE"] | ||||||
} | ||||||
|
||||||
variable "repository_creation_template_custom_role_arn" { | ||||||
description = "A custom IAM role to use for repository creation. Required if using repository tags or KMS encryption." | ||||||
type = string | ||||||
default = "" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
variable "repository_creation_template_description" { | ||||||
description = "The description for this template." | ||||||
type = string | ||||||
default = "" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
variable "repository_creation_template_image_tag_mutability" { | ||||||
description = "The tag mutability setting for any created repositories. Must be one of: MUTABLE or IMMUTABLE. Defaults to MUTABLE." | ||||||
type = string | ||||||
default = "MUTABLE" | ||||||
} | ||||||
|
||||||
variable "repository_creation_template_lifecycle_policy" { | ||||||
description = "The lifecycle policy document to apply to any created repositories. See more details about Policy Parameters in the official AWS docs. Consider using the aws_ecr_lifecycle_policy_document data_source to generate/manage the JSON document used for the lifecycle_policy argument." | ||||||
type = string | ||||||
default = "" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
variable "repository_creation_template_repository_policy" { | ||||||
description = "The registry policy document to apply to any created repositories. This is a JSON formatted string. For more information about building IAM policy documents with Terraform, see the AWS IAM Policy Document Guide." | ||||||
type = string | ||||||
default = null | ||||||
} | ||||||
|
||||||
variable "repository_creation_template_encryption_type" { | ||||||
description = "The encryption type for the repository. Must be one of: `KMS` or `AES256`. Defaults to `AES256`" | ||||||
type = string | ||||||
default = null | ||||||
} | ||||||
|
||||||
variable "repository_creation_template_kms_key" { | ||||||
description = "The ARN of the KMS key to use when encryption_type is `KMS`. If not specified, uses the default AWS managed key for ECR" | ||||||
type = string | ||||||
default = null | ||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ terraform { | |
required_providers { | ||
aws = { | ||
source = "hashicorp/aws" | ||
version = ">= 5.37" | ||
version = ">= 5.61" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.