Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Support rotation_period_in_days, AWS Provider v5, Terraform MSV 1.3 #32

Merged
merged 2 commits into from
May 11, 2024
Merged

feat!: Support rotation_period_in_days, AWS Provider v5, Terraform MSV 1.3 #32

merged 2 commits into from
May 11, 2024

Conversation

magreenbaum
Copy link
Member

Description

  • add support for rotation_period_in_days
  • aws provider version v5
  • terraform MSV 1.3

Motivation and Context

hashicorp/terraform-provider-aws#37140

Breaking Changes

  • aws provider version v5
  • terraform MSV 1.3

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

bryantbiggs
bryantbiggs approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit f8c96ce into terraform-aws-modules:master May 11, 2024
6 checks passed
antonbabenko pushed a commit that referenced this pull request May 11, 2024
@semantic-release-bot
chore(release): version 3.0.0 [skip ci]
8478d2d 
## [3.0.0](v2.2.1...v3.0.0) (2024-05-11)

### ⚠ BREAKING CHANGES

* Support `rotation_period_in_days`, AWS Provider v5, Terraform MSV 1.3 (#32)

### Features

* Support `rotation_period_in_days`, AWS Provider v5, Terraform MSV 1.3 ([#32](#32)) ([f8c96ce](f8c96ce))
@antonbabenko
Copy link
Member

This PR is included in version 3.0.0 🎉

@magreenbaum magreenbaum deleted the feat/rotation_period_in_days branch May 14, 2024 23:23
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magreenbaum @antonbabenko @bryantbiggs