Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for external integration with prometheus alertmanager for grafana #27

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

vickywilsonj
Copy link
Contributor

…ation with prometheus alertmanager for grafana. Added outputs for IAM policy.

Description

  1. Updated Prometheus policy document to add support for external integration with prometheus alertmanager for grafana. per https://docs.aws.amazon.com/prometheus/latest/userguide/integrating-grafana.html
  2. Added outputs for IAM policy created.
  3. Updated readme to include outputs for IAM policy.

Motivation and Context

Amazon Managed Grafana must have the following permissions for your Prometheus resources. You must add them to either the service-managed or customer-managed policies described in https://docs.aws.amazon.com/grafana/latest/userguide/AMG-manage-permissions.html.
aps:ListRules
aps:ListAlertManagerSilences
aps:ListAlertManagerAlerts
aps:GetAlertManagerStatus
aps:ListAlertManagerAlertGroups
aps:PutAlertManagerSilences
aps:DeleteAlertManagerSilences

Breaking Changes

No

How Has This Been Tested?

  • [ *] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ *] I have tested and validated these changes using one or more of the provided examples/* projects
  • [ *] I have executed pre-commit run -a on my pull request

…ation with prometheus alertmanager for grafana. Added outputs for IAM policy.
@vickywilsonj vickywilsonj changed the title Updated Prometheus policy document to add support for external integr… feat: Updated Prometheus policy document to add support for external integr… Oct 2, 2023
@vickywilsonj vickywilsonj changed the title feat: Updated Prometheus policy document to add support for external integr… feat: Updated Prometheus policy document to add support for external integration with prometheus alertmanager for grafana. Oct 2, 2023
@bryantbiggs bryantbiggs changed the title feat: Updated Prometheus policy document to add support for external integration with prometheus alertmanager for grafana. feat: Add support for external integration with prometheus alertmanager for grafana Oct 6, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit a4bd8f4 into terraform-aws-modules:master Oct 6, 2023
7 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 6, 2023
## [2.1.0](v2.0.0...v2.1.0) (2023-10-06)

### Features

* Add support for external integration with prometheus alertmanager for grafana ([#27](#27)) ([a4bd8f4](a4bd8f4))
@antonbabenko
Copy link
Member

This PR is included in version 2.1.0 🎉

@vickywilsonj
Copy link
Contributor Author

Thanks @antonbabenko and @bryantbiggs !

Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants