Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support disabling storage autoscaling #15

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

nishsak96
Copy link
Contributor

@nishsak96 nishsak96 commented Sep 14, 2023

…resources

Description

Added boolean option for creation of appautoscaling target and policy

Motivation and Context

MSK creation failing in regions without support for autoscaling resources

Resolves #14

Breaking Changes

No.

How Has This Been Tested?

  • [ No ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ No ] I have tested and validated these changes using one or more of the provided examples/* projects
  • [ No ] I have executed pre-commit run -a on my pull request

@nishsak96 nishsak96 changed the title bug: MSK creation failing in regions without support for autoscaling … fix: MSK creation failing in regions without support for autoscaling … Sep 14, 2023
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs changed the title fix: MSK creation failing in regions without support for autoscaling … feat: Support disabling storage autoscaling Sep 14, 2023
@bryantbiggs bryantbiggs merged commit 174d261 into terraform-aws-modules:master Sep 14, 2023
10 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 14, 2023
## [2.3.0](v2.2.0...v2.3.0) (2023-09-14)

### Features

* Support disabling storage autoscaling ([#15](#15)) ([174d261](174d261))
@antonbabenko
Copy link
Member

This PR is included in version 2.3.0 🎉

@nishsak96
Copy link
Contributor Author

Thanks @bryantbiggs and @antonbabenko.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto scaling target/policy creation failing in il-central-1
3 participants