Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for cloudwatch_log_group_class #36

Conversation

anden-dev
Copy link
Contributor

@anden-dev anden-dev commented Aug 8, 2024

Description

add optional variable cloudwatch_log_group_class (default: null)

A driveby contribution.

References:

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_group#log_group_class
https://github.com/hashicorp/terraform-provider-aws/releases?q=log_group_class&expanded=true

Motivation and Context

Resolves #33

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@anden-dev anden-dev force-pushed the feat/cloudwatch_loggroup_class branch from 72b6a85 to 27145ee Compare August 8, 2024 19:04
@anden-dev anden-dev force-pushed the feat/cloudwatch_loggroup_class branch from 27145ee to 85ea663 Compare August 8, 2024 19:06
@bryantbiggs bryantbiggs changed the title feat: add option to set cloudwatch_log_group_class feat: Add support for cloudwatch_log_group_class Aug 8, 2024
@bryantbiggs bryantbiggs merged commit 75244f0 into terraform-aws-modules:master Aug 8, 2024
10 of 12 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 8, 2024
## [2.8.0](v2.7.0...v2.8.0) (2024-08-08)

### Features

* Add support for `cloudwatch_log_group_class` ([#36](#36)) ([75244f0](75244f0))
@antonbabenko
Copy link
Member

This PR is included in version 2.8.0 🎉

Copy link

github-actions bot commented Sep 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudWatch log group class
3 participants