Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tags to AppAutoscaling target #44

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: Add tags to AppAutoscaling target #44

merged 1 commit into from
Nov 26, 2024

Conversation

mpdred
Copy link
Contributor

@mpdred mpdred commented Oct 30, 2024

Description

added tags attribute to aws_appautoscaling_target resource for consistent tagging across resources

Motivation and Context

this change adds tags to the autoscaling target, aligning with standardized tagging practices. enhances visibility and management of resources within AWS

Breaking Changes

no breaking changes; this addition is backward-compatible with the existing configuration

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@mpdred mpdred marked this pull request as ready for review October 30, 2024 14:20
@mpdred
Copy link
Contributor Author

mpdred commented Oct 30, 2024

the org that I'm part of has an explicit deny in the service control policy for IAM, causing resources to fail creation without proper tagging in place

@mpdred
Copy link
Contributor Author

mpdred commented Nov 26, 2024

@antonbabenko , could you kindly take a moment to check this out?

@bryantbiggs bryantbiggs changed the title fix: Add tags support to aws_appautoscaling_target feat: Add tags to AppAutoscaling target Nov 26, 2024
@bryantbiggs bryantbiggs merged commit f0857f3 into terraform-aws-modules:master Nov 26, 2024
11 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 26, 2024
@semantic-release-bot
chore(release): version 2.10.0 [skip ci]
65d6c25 
## [2.10.0](v2.9.0...v2.10.0) (2024-11-26)

### Features

* Add tags to AppAutoscaling target ([#44](#44)) ([f0857f3](f0857f3))

### Bug Fixes

* Update CI workflow versions to latest ([#42](#42)) ([d0682a9](d0682a9))
@antonbabenko
Copy link
Member

This PR is included in version 2.10.0 🎉

@mpdred mpdred deleted the add-tags-for-aws_appautoscaling_target branch November 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpdred @antonbabenko @bryantbiggs