chore: Add cluster name to outputs #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes it's usefull to have this value as output, for instance, when using terragrunt and use this module as dependency of another module
wladyslawczyzewski
changed the title
wladyslawczyzewski
changed the title
|
that won't do what you think it does - you would need to take an implicit dependency on the cluster ARN in this case https://github.com/hashicorp/terraform-provider-aws/blob/f75b604ed2ccc1618be162393b623de3f232bb57/internal/service/kafka/cluster.go#L597 but we can output the name - see note on change though to get generated name |
bryantbiggs
reviewed
Nov 29, 2024
| @@ -37,6 +37,11 @@ output "bootstrap_brokers_tls" { | |||
| value = try(aws_msk_cluster.this[0].bootstrap_brokers_tls, null) | |||
| } | |||
|
|
|||
| output "cluster_name" { | |||
| description = "Name of the MSK cluster" | |||
| value = var.name | |||
There was a problem hiding this comment.
Suggested change
| value = var.name | |
| value = try(aws_msk_cluster.this[0].cluster_name, null) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes it's useful to have this value as output, for instance, when using terragrunt and use this module as dependency of another module.
Motivation and Context
Just adds the output with cluster name. Useful when using module as dependency of another module.
Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request