fix: Create a domain policy that implicitly depends_on domain #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If do not establish implicit dependencies, a error is displayed when create a domain policy indicating that the specified domain cannot be found
Update main.tf，domain_policy implicitly depends on domain
hougang512
changed the title
bryantbiggs
approved these changes
Jun 28, 2024
bryantbiggs
merged commit 473ba5d
into
terraform-aws-modules:master
13 of 19 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Jun 28, 2024
## [1.2.1](v1.2.0...v1.2.1) (2024-06-28) ### Bug Fixes * Create a domain policy that implicitly depends_on domain ([#15](#15)) ([473ba5d](473ba5d))
|
This PR is included in version 1.2.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a domain policy that implicitly depends_on domain
Motivation and Context
When creating a domain policy through the var.access_policies variable, terraform execution fails and prompts that the specified domain cannot be found,
The above problem can be solved by establishing an implicit depends_on between domain policy and domain
Breaking Changes
no
How Has This Been Tested?
I have passed the test
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request