Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct evaluation logic when determining master_user_options arguments #20

Merged

Conversation

dim-ops
Copy link
Contributor

@dim-ops dim-ops commented Jul 2, 2024

Description

#18

How Has This Been Tested?

advanced_security_options = {
    enabled                        = true
    anonymous_auth_enabled         = false
    internal_user_database_enabled = true

    master_user_options = {
      master_user_name     = "admin"
      master_user_password = "PasswoRd12-"
    }
  }
advanced_security_options = {
    enabled                        = true
    anonymous_auth_enabled         = false
    internal_user_database_enabled = false

    master_user_options = {
      master_user_arn     = aws_iam_user.opensearch_cluster.arn
    }
  }

@dim-ops dim-ops force-pushed the fix-master_user_arn branch from 13fcc59 to 88566ab Compare July 2, 2024 13:17
@velkovb
Copy link

velkovb commented Jul 2, 2024

I think that will fix #19. I was planning a PR but you got it first :)

@bryantbiggs bryantbiggs changed the title fix(master_user): To allow arn as master_user_arn fix: Correct evaluation logic when determining master_user_options arguments Jul 5, 2024
@bryantbiggs bryantbiggs merged commit 7d00ee2 into terraform-aws-modules:master Jul 5, 2024
8 checks passed
antonbabenko pushed a commit that referenced this pull request Jul 5, 2024
## [1.3.1](v1.3.0...v1.3.1) (2024-07-05)

### Bug Fixes

* Correct evaluation logic when determining `master_user_options` arguments ([#20](#20)) ([7d00ee2](7d00ee2))
@antonbabenko
Copy link
Member

This PR is included in version 1.3.1 🎉

Copy link

github-actions bot commented Aug 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants