Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set schema as optional for external tables #276

Conversation

msgongora
Copy link
Contributor

When using auto-detect mechanism, external table schema isn't needed. Hence, optional.

Ref: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#externaldataconfiguration

Optional. The schema for the data. Schema is required for CSV and JSON formats if autodetect is not on. Schema is disallowed for Google Cloud Bigtable, Cloud Datastore backups, Avro, ORC and Parquet formats.

https://github.com/hashicorp/terraform-provider-google/blob/3d7632af6b73a3edae04c7204a38525b7a5f6262/google/services/bigquery/resource_bigquery_table.go#L498-L502

@msgongora msgongora requested review from davenportjw and a team as code owners October 26, 2023 21:07
@msgongora msgongora force-pushed the feat/external-bq-omni branch from b823377 to be4314d Compare October 26, 2023 21:09
@msgongora msgongora changed the title set schema as optional for external table fix: set schema as optional for external tables Oct 30, 2023
@msgongora msgongora force-pushed the feat/external-bq-omni branch from 77d4a7a to 3a90a16 Compare November 10, 2023 20:35
@msgongora msgongora force-pushed the feat/external-bq-omni branch from 3a90a16 to 9efef69 Compare November 29, 2023 23:31
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Feb 11, 2024
@github-actions github-actions bot closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant