feat: add storage_billing_model and default_partition_expiration_ms #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Add default_partition_expiration_ms
SamuZad
changed the title
|
@davenportjw @shanecglass any chance we could get a review for this? |
|
/gcbrun |
|
/gcbrun |
Co-authored-by: Awais Malik <[email protected]>
|
@g-awmalik thank you! Made the suggested change |
|
@g-awmalik any chance for a merge? |
|
any news about this PR ? |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #235 (which previously had a PR that was cancelled) and #333
Adds the option to specify
storage_billing_modelAlso adds in validation for
storage_billing_modelAdds the option to specify
default_partition_expiration_msRegarding validation, I've wanted to preserve the default behaviour of the underlying terraform resource so the default of
storage_billing_modelisnull. This is to make the addition of this variable as seamless as possible. However, this means that I can't use the contains function to validate the variable, ascontains()errors out if what it checks is null